This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Link to print a whole part #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new sidebar which contains a link to print a whole CFR part and includes it in the base list of sidebars. It also enlarges the sidebar chevrons.
|
Thanks @theresaanna ! I'll bump up the version then merge |
|
Pausing this until we resolve a potential bug around a missing popup. |
|
@theresaanna and I misunderstood; there wasn't a bug, so I'll merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a (default) sidebar link and popups the print dialog whenever "print=true" is a query param.
Looks like
There is a little jankiness around scroll state (notably, the subheader and position in the table-of-contents don't change as you scroll) on this whole-part page.