This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Fix dependencies #516
Merged
Fix dependencies #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 14, 2018 11:36
Recent versions of `futures` are no longer compatible with python 3, which causes error on fresh installation. This resolves by limiting when `futures` and `enum34` (which has similar version dependencies) are installed.
Support for environment markers was added in the first half of 2016, but there's no guarantee that's up to date on the user's system.
tadhg-ohiggins
approved these changes
May 14, 2018
|
Thanks @tadhg-ohiggins ! |
cmc333333
pushed a commit
to cmc333333/regulations-site
that referenced
this pull request
May 15, 2018
Bug Fixes * Ensure compatibility with recent versions of futures/enum34 eregs#516 * Avoid 500 when missing data eregs#515 (thanks to first time contributor, @lbeaufort!) * Fix bug which would turn §ion links into §
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of
futureswill explode if trying to install into Python 3, so this limits installation to appropriate versions of Python. Unfortunately, the syntax used was only added tosetuptoolsin 2016, so this also adds a note about updating that.