Implementing DEFAULT_TRAY_OFFSET_Y#105
Open
evilbaschdi wants to merge 1 commit intoerez-c137:mainfrom
Open
Conversation
…erting logic into more reliable `math.ceil` calculations with less horizontal complexity. - Updated the `DEFAULT_TRAY_OFFSET_Y` to match the previous value of `DEFAULT_TRAY_OFFSET_X`. - Converts horizontal and vertical taskbar logic to use `math.ceil` for better precision. - Rearranged and extended the UI elements for the offsets label, changing horizontal offset to vertical. - Added a constant field `calculated_height` with a default value derived from the metrics' height and margins, but removed a former fallback logic that used to determine the calculation based on taskbar area.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes were made for accurate positioning of taskbar offsets by converting logic into more reliable
math.ceilcalculations with less horizontal complexity.DEFAULT_TRAY_OFFSET_Yto match the previous value ofDEFAULT_TRAY_OFFSET_X.math.ceilfor better precision.calculated_heightwith a default value derived from the metrics' height and margins, but removed a former fallback logic that used to determine the calculation based on taskbar area.Does not completly solve #104 but provides options to deal with it.