fix!: don't quote CloudWatch filter pattern #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
changed the title
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
calebwilson706
approved these changes
Oct 21, 2022
Pull Request Test Coverage Report for Build 3296887009
💛 - Coveralls |
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 21, 2022
🤖 I have created a release *beep* *boop* --- ## [3.0.0](v2.1.7...v3.0.0) (2022-10-21) ### ⚠ BREAKING CHANGES * The filter pattern to match CloudWatch Logs is now passed without modifications to the AWS API. If you're using the Jest `toHaveLog` or Chai `to.have.log` matchers you might need to quote your pattern, e.g. `toHaveLog(pattern) -> toHaveLog("${pattern}")` or `to.have.log(pattern) -> to.have.log("${pattern}")` to support special characters ### Bug Fixes * don't quote CloudWatch filter pattern ([#702](#702)) ([aef13c0](aef13c0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other way to fix #696.
This is a breaking change so will be released as a new major version bump