Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: require Node.js 16 #711

Merged
merged 3 commits into from
Oct 30, 2022
Merged

chore: require Node.js 16 #711

merged 3 commits into from
Oct 30, 2022

Conversation

erezrokah
Copy link
Owner

@erezrokah erezrokah commented Oct 30, 2022

BREAKING CHANGE: require Node.js 16 as 12,14 are EOF/Nearing EOF. This is a first step in moving to a pure ESM package. If you're already running on Node.js >= 16 this shouldn't be breaking for you, as the library is still compiled to commonJS.

@coveralls
Copy link

coveralls commented Oct 30, 2022

Pull Request Test Coverage Report for Build 3356812266

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.726%

Totals Coverage Status
Change from base Build 3351464159: 0.0%
Covered Lines: 606
Relevant Lines: 606

💛 - Coveralls

@erezrokah erezrokah merged commit 69458cc into main Oct 30, 2022
@erezrokah erezrokah deleted the chore/require_node_16 branch October 30, 2022 19:46
@erezrokah erezrokah restored the chore/require_node_16 branch October 30, 2022 20:09
kodiakhq bot pushed a commit that referenced this pull request Nov 2, 2022
🤖 I have created a release *beep* *boop*
---


##
[4.0.0](v3.0.2...v4.0.0)
(2022-10-30)


### ⚠ BREAKING CHANGES

* require Node.js 16.10.0 as 12,14 are EOF/Nearing EOF. This is a first
step in moving to a pure ESM package. If you're already running on
Node.js >= 16.10.0 this shouldn't be breaking for you, as the library is
still compiled to commonJS

### Miscellaneous Chores

* require Node.js 16
([#711](#711))
([69458cc](69458cc))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants