-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removing dependency on filter-obj #782
base: main
Are you sure you want to change the base?
removing dependency on filter-obj #782
Conversation
@erezrokah do u have time to see this PR? |
looks good! |
Hi everyone, I'm currently on vacation and will be able to take a look only in a week or two |
Hey! Any updates on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @renanbym and sorry for just responding now.
I'd prefer if we find a solution that doesn't require inlining dependencies as that comes with the following disadvantages:
- Is copy pastes code from another open source project without giving credit to the original author
- It doesn't include any test coverage for the copy pasted code
- It means we won't get fixes or updates to the copy pasted code
Regarding this specific change it seems the underlying issue is with Jest support of ESM. I didn't have the time to respond to the issue with a valid configuration, but the example here runs with Jest and a version of aws-testing-library
that uses filter-obj
.
The plan is to make aws-testing-library
ESM only too (once I have time to do it).
This is probably related to that issue. After updating
What do you think I should do? @erezrokah, what's the progress on making |
removing dependency on filter-obj
dependency has been causing problems since the >4.0.0 update