Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the hack that allowed ERF's Bomex simulations to match Siebesma (2003). The current formulation is applied to all scalars and needs verifying that it preserves the properties of the hack (which was only applied to
qc
). Furthermore, the choice to forward predict withcur_cons
instead ofold_cons
is open to discussion/interpretation.Before merging, a run out to 7200 [s] on the BOMEX case will be completed and the results will be posted here. The cloud cover and
qc
fields will be considered).