Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monotonic Advection #1707

Merged
merged 6 commits into from
Jul 29, 2024
Merged

Monotonic Advection #1707

merged 6 commits into from
Jul 29, 2024

Conversation

AMLattanzi
Copy link
Collaborator

@AMLattanzi AMLattanzi commented Jul 23, 2024

This PR extends the hack that allowed ERF's Bomex simulations to match Siebesma (2003). The current formulation is applied to all scalars and needs verifying that it preserves the properties of the hack (which was only applied to qc). Furthermore, the choice to forward predict with cur_cons instead of old_cons is open to discussion/interpretation.

Before merging, a run out to 7200 [s] on the BOMEX case will be completed and the results will be posted here. The cloud cover and qc fields will be considered).

@AMLattanzi
Copy link
Collaborator Author

AMLattanzi commented Jul 24, 2024

Local BOMEX run yielded the following results (simulation terminated at ~9k [s]). Note, blue line is last instantaneous plane average, red is 1 hr time average of plane averages, and colored lines are each instantaneous plane average.
image
image

@AMLattanzi AMLattanzi merged commit 2e9a159 into erf-model:development Jul 29, 2024
18 checks passed
@AMLattanzi AMLattanzi deleted the MonoAdv branch November 12, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant