Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cosine with Warmup Scheduler #2

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

w11wo
Copy link
Contributor

@w11wo w11wo commented Mar 18, 2024

I've been training LLMs with EasyDeL and noticed that my learning rates aren't warming up and decaying properly when using the Cosine with Linear Warmup scheduler (it is always warming up and never decaying). Looks like this should fix it.

Reference: Optax Docs

@erfanzar
Copy link
Owner

Thanks for contributing to FJFormer❤️

@erfanzar erfanzar merged commit 36d0f62 into erfanzar:main Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants