Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add integration tests #129

Merged
merged 6 commits into from
Dec 23, 2018
Merged

Fix: Add integration tests #129

merged 6 commits into from
Dec 23, 2018

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Dec 14, 2018

This PR

  • removes useless unit tests
  • removes auto-reviewtests
  • turns empty unit into integration test suite
  • requires symfony/filesystem as development dependency
  • adds integration tests
  • requires composer/composer:^1.8.0 as development dependency

Follows #117.

@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #129 into 1.x will decrease coverage by 26.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##                1.x   #129       +/-   ##
===========================================
- Coverage     26.03%     0%   -26.04%     
  Complexity       34     34               
===========================================
  Files             2      2               
  Lines           169    223       +54     
===========================================
- Hits             44      0       -44     
- Misses          125    223       +98
Impacted Files Coverage Δ Complexity Δ
src/NormalizePlugin.php 0% <0%> (-100%) 3% <0%> (ø)
src/Command/NormalizeCommand.php 0% <0%> (-21.88%) 31% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beacaaf...1ad8b7b. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #129 into 1.x will increase coverage by 51.47%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##                1.x     #129       +/-   ##
=============================================
+ Coverage     26.03%   77.51%   +51.47%     
  Complexity       34       34               
=============================================
  Files             2        2               
  Lines           169      169               
=============================================
+ Hits             44      131       +87     
+ Misses          125       38       -87
Impacted Files Coverage Δ Complexity Δ
src/NormalizePlugin.php 0% <0%> (-100%) 3% <0%> (ø)
src/Command/NormalizeCommand.php 81.87% <0%> (+60%) 31% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f620899...a6ea715. Read the comment docs.

@localheinz localheinz force-pushed the fix/test branch 12 times, most recently from 7c4e45a to e3cb3b8 Compare December 21, 2018 10:52
@localheinz localheinz force-pushed the fix/test branch 2 times, most recently from 2326f25 to e15c158 Compare December 23, 2018 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant