Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Update locker when locker is not fresh after normalization #139

Merged
merged 2 commits into from
Dec 24, 2018
Merged

Fix: Update locker when locker is not fresh after normalization #139

merged 2 commits into from
Dec 24, 2018

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Dec 24, 2018 •
edited
Loading

This PR

  • asserts that composer.lock is updated after normalization
  • resets composer after normalization
  • passes --working-dir option when updating locker and file argument was specified

Fixes #98.

@localheinz localheinz added the bug label Dec 24, 2018
@localheinz localheinz self-assigned this Dec 24, 2018
@codecov
Copy link

codecov bot commented Dec 24, 2018

Codecov Report

❗ No coverage uploaded for pull request base (1.x@591535d). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##             1.x     #139   +/-   ##
======================================
  Coverage       ?   82.87%           
  Complexity     ?       36           
======================================
  Files          ?        2           
  Lines          ?      181           
  Branches       ?        0           
======================================
  Hits           ?      150           
  Misses         ?       31           
  Partials       ?        0
Impacted Files Coverage Δ Complexity Δ
src/Command/NormalizeCommand.php 87.2% <100%> (ø) 33 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 591535d...543bb46. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 24, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (1.x@0ffb6c9). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##             1.x     #139   +/-   ##
======================================
  Coverage       ?   82.87%           
  Complexity     ?       36           
======================================
  Files          ?        2           
  Lines          ?      181           
  Branches       ?        0           
======================================
  Hits           ?      150           
  Misses         ?       31           
  Partials       ?        0
Impacted Files Coverage Δ Complexity Δ
src/Command/NormalizeCommand.php 87.2% <100%> (ø) 33 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ffb6c9...d653003. Read the comment docs.

@localheinz localheinz mentioned this pull request Dec 24, 2018
Closed
@localheinz localheinz added this to the 1.1.0 milestone Dec 24, 2018
@localheinz localheinz merged commit fb907fb into 1.x Dec 24, 2018
@localheinz localheinz deleted the fix/update branch December 24, 2018 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@localheinz localheinz

Labels
bug
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@localheinz