Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove default values of $formatter and $differ parameters #262

Merged
merged 1 commit into from
Dec 15, 2019

Conversation

localheinz
Copy link
Member

This PR

  • removes default values for parameters $formatter and $differ of constructor of Localheinz\Composer\Normalize\Command\NormalizeCommand

@localheinz localheinz added the bug label Dec 15, 2019
@localheinz localheinz self-assigned this Dec 15, 2019
@codecov
Copy link

codecov bot commented Dec 15, 2019

Codecov Report

Merging #262 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #262   +/-   ##
=======================================
  Coverage        80%    80%           
+ Complexity       43     39    -4     
=======================================
  Files             3      3           
  Lines           175    175           
=======================================
  Hits            140    140           
  Misses           35     35
Impacted Files Coverage Δ Complexity Δ
src/Command/NormalizeCommand.php 88.07% <100%> (-0.24%) 32 <0> (-4)
src/NormalizePlugin.php 70% <100%> (+12.85%) 3 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e77658c...69c94cc. Read the comment docs.

@localheinz localheinz marked this pull request as ready for review December 15, 2019 21:06
@localheinz localheinz merged commit 97b77ae into master Dec 15, 2019
@localheinz localheinz deleted the fix/default branch December 15, 2019 21:07
@localheinz localheinz changed the title Fix: Remove default values of $formatter abd $differ parameters Fix: Remove default values of $formatter and $differ parameters Dec 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant