Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Update schema #322

Merged
merged 1 commit into from
Jan 14, 2020
Merged

Enhancement: Update schema #322

merged 1 commit into from
Jan 14, 2020

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Jan 14, 2020

This PR

  • updates schema.json

💁‍♂ For reference, see composer/composer@b667361#diff-1619accaf94d67d2012404383625d527.

@localheinz localheinz self-assigned this Jan 14, 2020
@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #322 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #322   +/-   ##
=========================================
  Coverage     87.43%   87.43%           
  Complexity       38       38           
=========================================
  Files             4        4           
  Lines           191      191           
=========================================
  Hits            167      167           
  Misses           24       24

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47faa14...e619a86. Read the comment docs.

@localheinz localheinz merged commit 782ee45 into master Jan 14, 2020
@localheinz localheinz deleted the feature/schema branch January 14, 2020 12:29
@szepeviktor
Copy link
Contributor

@localheinz Oh! The first fruit of the schema checking :)

@localheinz
Copy link
Member Author

@szepeviktor

Unfortunately the run that updates it automatically failed: https://github.com/ergebnis/composer-normalize/commit/47faa141ae588f82693eee21a5843242bb625ca7/checks?check_suite_id=399719909.

I can probably work around by adding myself to the list of users who can push to master, but I'd prefer not to!

Also see https://github.saobby.my.eu.orgmunity/t5/GitHub-Actions/Who-will-be-the-GitHub-actor-when-a-workflow-runs-on-a-schedule/m-p/43362#M5355.

@szepeviktor
Copy link
Contributor

szepeviktor commented Jan 14, 2020

I see.
Maybe having the scheduler to open a PR would be more livable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants