Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Throw exception when environment variable could not be unset #15

Merged
merged 1 commit into from
Feb 23, 2020

Conversation

localheinz
Copy link
Member

This PR

  • throws an exception when a system environment variable could not be unset

@localheinz localheinz self-assigned this Feb 23, 2020
@codecov
Copy link

codecov bot commented Feb 23, 2020

Codecov Report

Merging #15 into master will decrease coverage by 0.78%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #15      +/-   ##
============================================
- Coverage     99.14%   98.36%   -0.79%     
- Complexity       64       66       +2     
============================================
  Files             9       10       +1     
  Lines           117      122       +5     
============================================
+ Hits            116      120       +4     
- Misses            1        2       +1
Impacted Files Coverage Δ Complexity Δ
src/Exception/CouldNotUnset.php 100% <100%> (ø) 1 <1> (?)
src/SystemVariables.php 90.9% <50%> (-4.1%) 14 <0> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1b51f4...0782da3. Read the comment docs.

@localheinz localheinz merged commit c68a887 into master Feb 23, 2020
@localheinz localheinz deleted the feature/could-not-unset branch February 23, 2020 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant