Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Accept closure instead of array #101

Merged
merged 1 commit into from
Mar 28, 2020

Conversation

localheinz
Copy link
Member

This PR

  • turns the $configuration parameter of FixtureFactory::defineEntity() into $afterCreate, an optional closure that is invoked after object creation

Follows #1.

💁‍♂ The $configuration only ever handled an afterCreate key so far anyway.

@localheinz localheinz self-assigned this Mar 28, 2020
@codecov
Copy link

codecov bot commented Mar 28, 2020

Codecov Report

Merging #101 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #101      +/-   ##
============================================
+ Coverage     93.71%   93.77%   +0.06%     
- Complexity       75       76       +1     
============================================
  Files             9        9              
  Lines           207      209       +2     
============================================
+ Hits            194      196       +2     
  Misses           13       13              
Impacted Files Coverage Δ Complexity Δ
src/EntityDefinition.php 100.00% <100.00%> (ø) 4.00 <2.00> (ø)
src/FixtureFactory.php 91.73% <100.00%> (+0.13%) 44.00 <10.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9346895...2efab30. Read the comment docs.

@localheinz localheinz merged commit 4a132f6 into master Mar 28, 2020
@localheinz localheinz deleted the feature/after-create branch March 28, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant