Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Throw InvalidCount exception #105

Merged
merged 1 commit into from
Mar 28, 2020
Merged

Conversation

localheinz
Copy link
Member

This PR

  • throws an InvalidCount exception when an invalid number of entities is requested

Follows #87.

@localheinz localheinz self-assigned this Mar 28, 2020
@codecov
Copy link

codecov bot commented Mar 28, 2020

Codecov Report

Merging #105 into master will increase coverage by 0.74%.
The diff coverage is 94.73%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #105      +/-   ##
============================================
+ Coverage     93.75%   94.49%   +0.74%     
- Complexity       76       77       +1     
============================================
  Files             9       10       +1     
  Lines           208      218      +10     
============================================
+ Hits            195      206      +11     
+ Misses           13       12       -1     
Impacted Files Coverage Δ Complexity Δ
src/FixtureFactory.php 91.86% <88.88%> (+0.20%) 44.00 <5.00> (ø)
src/Exception/InvalidCount.php 100.00% <100.00%> (ø) 1.00 <1.00> (?)
src/FieldDefinition.php 100.00% <100.00%> (+4.34%) 6.00 <2.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa17921...20bf74f. Read the comment docs.

@localheinz localheinz merged commit ed73b90 into master Mar 28, 2020
@localheinz localheinz deleted the feature/invalid-count branch March 28, 2020 16:30
@localheinz localheinz mentioned this pull request Mar 31, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant