Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Throw EntityDefinitionAlreadyRegistered exception #106

Merged
merged 1 commit into from
Mar 28, 2020

Conversation

localheinz
Copy link
Member

This PR

  • throws an EntityDefinitionAlreadyRegistered exception when an entity definition has already been registered for a class name

Follows #86.

@localheinz localheinz self-assigned this Mar 28, 2020
@codecov
Copy link

codecov bot commented Mar 28, 2020

Codecov Report

Merging #106 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #106      +/-   ##
============================================
+ Coverage     94.49%   94.54%   +0.05%     
- Complexity       77       80       +3     
============================================
  Files            10       11       +1     
  Lines           218      220       +2     
============================================
+ Hits            206      208       +2     
  Misses           12       12              
Impacted Files Coverage Δ Complexity Δ
...rc/Exception/EntityDefinitionAlreadyRegistered.php 100.00% <100.00%> (ø) 2.00 <2.00> (?)
src/FixtureFactory.php 91.80% <100.00%> (-0.07%) 45.00 <0.00> (+1.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed73b90...75ae235. Read the comment docs.

@localheinz localheinz force-pushed the feature/entity-definition-already-registered branch from 33c3149 to 75ae235 Compare March 28, 2020 17:17
@localheinz localheinz merged commit 6ff1525 into master Mar 28, 2020
@localheinz localheinz deleted the feature/entity-definition-already-registered branch March 28, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant