Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Rename exception #107

Merged
merged 1 commit into from
Mar 29, 2020
Merged

Fix: Rename exception #107

merged 1 commit into from
Mar 29, 2020

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Mar 28, 2020 •
edited
Loading

This PR

  • renames an exception

Follows #6.

@localheinz localheinz added the bug label Mar 28, 2020
@localheinz localheinz self-assigned this Mar 28, 2020
@localheinz localheinz force-pushed the fix/rename branch 2 times, most recently from 2bb70c8 to a7e0050 Compare March 28, 2020 17:55
@codecov
Copy link

codecov bot commented Mar 28, 2020 •
edited
Loading

Codecov Report

Merging #107 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #107   +/-   ##
=========================================
  Coverage     94.54%   94.54%           
  Complexity       80       80           
=========================================
  Files            11       11           
  Lines           220      220           
=========================================
  Hits            208      208           
  Misses           12       12
Impacted Files Coverage Δ Complexity Δ
src/Exception/EntityDefinitionNotRegistered.php 100.00% <ø> (ø) 2.00 <0.00> (?)
src/FixtureFactory.php 91.80% <100.00%> (ø) 45.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ff1525...50c3d28. Read the comment docs.

@localheinz localheinz changed the title Fix: Rename exception [DO NOT MERGE] Fix: Rename exception Mar 28, 2020
@localheinz localheinz mentioned this pull request Mar 28, 2020
Closed
@localheinz localheinz changed the title [DO NOT MERGE] Fix: Rename exception Fix: Rename exception Mar 29, 2020
@localheinz
Copy link
Member Author

Build failure are related to vimeo/psalm#2191.

@localheinz localheinz merged commit e230ec8 into master Mar 29, 2020
@localheinz localheinz deleted the fix/rename branch March 29, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@localheinz localheinz

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@localheinz