Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Reject invalid field definition values #142

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Conversation

localheinz
Copy link
Member

This PR

  • rejects invalid field definition values from the constructor of EntityDefinition

@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #142 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #142      +/-   ##
============================================
+ Coverage     98.01%   98.08%   +0.06%     
- Complexity       72       74       +2     
============================================
  Files            12       13       +1     
  Lines           202      209       +7     
============================================
+ Hits            198      205       +7     
  Misses            4        4              
Impacted Files Coverage Δ Complexity Δ
src/EntityDefinition.php 100.00% <100.00%> (ø) 5.00 <0.00> (+1.00)
src/Exception/InvalidFieldDefinitions.php 100.00% <100.00%> (ø) 1.00 <1.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15b85a7...6895a5d. Read the comment docs.

@ergebnis-bot ergebnis-bot self-assigned this Mar 31, 2020
@ergebnis-bot ergebnis-bot self-requested a review March 31, 2020 18:56
@ergebnis-bot ergebnis-bot merged commit 746b0a2 into master Mar 31, 2020
@ergebnis-bot ergebnis-bot deleted the fix/reject branch March 31, 2020 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants