Fix: Improve tests for Definitions

.github/workflows/integrate.yaml

@@ -9,8 +9,8 @@ on: # yamllint disable-line rule:truthy
       - "main"
 
 env:
-  MIN_COVERED_MSI: 96
-  MIN_MSI: 96
+  MIN_COVERED_MSI: 97
+  MIN_MSI: 97
   PHP_EXTENSIONS: "mbstring"
 
 jobs:

Makefile

@@ -1,5 +1,5 @@
-MIN_COVERED_MSI:=96
-MIN_MSI:=96
+MIN_COVERED_MSI:=97
+MIN_MSI:=97
 
 .PHONY: it
 it: coding-standards static-code-analysis tests ## Runs the coding-standards, static-code-analysis, and tests targets

test/Fixture/Definitions/DoesNotImplementDefinition/OrganizationDefinition.php

@@ -0,0 +1,26 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * Copyright (c) 2020 Andreas Möller
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE.md file that was distributed with this source code.
+ *
+ * @see https://github.com/ergebnis/factory-bot
+ */
+
+namespace Ergebnis\FactoryBot\Test\Fixture\Definitions\DoesNotImplementDefinition;
+
+use Ergebnis\FactoryBot\Definition;
+use Ergebnis\FactoryBot\FixtureFactory;
+use Ergebnis\FactoryBot\Test\Fixture;
+
+final class OrganizationDefinition implements Definition
+{
+    public function accept(FixtureFactory $fixtureFactory): void
+    {
+        $fixtureFactory->define(Fixture\FixtureFactory\Entity\Organization::class);
+    }
+}

test/Fixture/Definitions/DoesNotImplementDefinition/UserDefinition.php

@@ -0,0 +1,26 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * Copyright (c) 2020 Andreas Möller
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE.md file that was distributed with this source code.
+ *
+ * @see https://github.com/ergebnis/factory-bot
+ */
+
+namespace Ergebnis\FactoryBot\Test\Fixture\Definitions\DoesNotImplementDefinition;
+
+use Ergebnis\FactoryBot\Definition;
+use Ergebnis\FactoryBot\FixtureFactory;
+use Ergebnis\FactoryBot\Test\Fixture;
+
+final class UserDefinition implements Definition
+{
+    public function accept(FixtureFactory $fixtureFactory): void
+    {
+        $fixtureFactory->define(Fixture\FixtureFactory\Entity\User::class);
+    }
+}

test/Fixture/Definitions/ImplementsDefinition/OrganizationDefinition.php

@@ -0,0 +1,26 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * Copyright (c) 2020 Andreas Möller
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE.md file that was distributed with this source code.
+ *
+ * @see https://github.com/ergebnis/factory-bot
+ */
+
+namespace Ergebnis\FactoryBot\Test\Fixture\Definitions\ImplementsDefinition;
+
+use Ergebnis\FactoryBot\Definition;
+use Ergebnis\FactoryBot\FixtureFactory;
+use Ergebnis\FactoryBot\Test\Fixture;
+
+final class OrganizationDefinition implements Definition
+{
+    public function accept(FixtureFactory $fixtureFactory): void
+    {
+        $fixtureFactory->define(Fixture\FixtureFactory\Entity\Organization::class);
+    }
+}

test/Fixture/Definitions/ImplementsDefinition/UserDefinition.php

@@ -0,0 +1,26 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * Copyright (c) 2020 Andreas Möller
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE.md file that was distributed with this source code.
+ *
+ * @see https://github.com/ergebnis/factory-bot
+ */
+
+namespace Ergebnis\FactoryBot\Test\Fixture\Definitions\ImplementsDefinition;
+
+use Ergebnis\FactoryBot\Definition;
+use Ergebnis\FactoryBot\FixtureFactory;
+use Ergebnis\FactoryBot\Test\Fixture;
+
+final class UserDefinition implements Definition
+{
+    public function accept(FixtureFactory $fixtureFactory): void
+    {
+        $fixtureFactory->define(Fixture\FixtureFactory\Entity\User::class);
+    }
+}

test/Fixture/Definitions/ImplementsDefinitionButHasPrivateConstructor/OrganizationDefinition.php

@@ -0,0 +1,26 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * Copyright (c) 2020 Andreas Möller
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE.md file that was distributed with this source code.
+ *
+ * @see https://github.com/ergebnis/factory-bot
+ */
+
+namespace Ergebnis\FactoryBot\Test\Fixture\Definitions\ImplementsDefinitionButHasPrivateConstructor;
+
+use Ergebnis\FactoryBot\Definition;
+use Ergebnis\FactoryBot\FixtureFactory;
+use Ergebnis\FactoryBot\Test\Fixture;
+
+final class OrganizationDefinition implements Definition
+{
+    public function accept(FixtureFactory $fixtureFactory): void
+    {
+        $fixtureFactory->define(Fixture\FixtureFactory\Entity\Organization::class);
+    }
+}

test/Fixture/Definitions/ImplementsDefinitionButHasPrivateConstructor/UserDefinition.php

@@ -0,0 +1,26 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * Copyright (c) 2020 Andreas Möller
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE.md file that was distributed with this source code.
+ *
+ * @see https://github.com/ergebnis/factory-bot
+ */
+
+namespace Ergebnis\FactoryBot\Test\Fixture\Definitions\ImplementsDefinitionButHasPrivateConstructor;
+
+use Ergebnis\FactoryBot\Definition;
+use Ergebnis\FactoryBot\FixtureFactory;
+use Ergebnis\FactoryBot\Test\Fixture;
+
+final class UserDefinition implements Definition
+{
+    public function accept(FixtureFactory $fixtureFactory): void
+    {
+        $fixtureFactory->define(Fixture\FixtureFactory\Entity\User::class);
+    }
+}

test/Fixture/Definitions/ImplementsDefinitionButIsAbstract/OrganizationDefinition.php

@@ -0,0 +1,26 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * Copyright (c) 2020 Andreas Möller
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE.md file that was distributed with this source code.
+ *
+ * @see https://github.com/ergebnis/factory-bot
+ */
+
+namespace Ergebnis\FactoryBot\Test\Fixture\Definitions\ImplementsDefinitionButIsAbstract;
+
+use Ergebnis\FactoryBot\Definition;
+use Ergebnis\FactoryBot\FixtureFactory;
+use Ergebnis\FactoryBot\Test\Fixture;
+
+final class OrganizationDefinition implements Definition
+{
+    public function accept(FixtureFactory $fixtureFactory): void
+    {
+        $fixtureFactory->define(Fixture\FixtureFactory\Entity\Organization::class);
+    }
+}

test/Fixture/Definitions/ImplementsDefinitionButIsAbstract/UserDefinition.php

@@ -0,0 +1,26 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * Copyright (c) 2020 Andreas Möller
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE.md file that was distributed with this source code.
+ *
+ * @see https://github.com/ergebnis/factory-bot
+ */
+
+namespace Ergebnis\FactoryBot\Test\Fixture\Definitions\ImplementsDefinitionButIsAbstract;
+
+use Ergebnis\FactoryBot\Definition;
+use Ergebnis\FactoryBot\FixtureFactory;
+use Ergebnis\FactoryBot\Test\Fixture;
+
+final class UserDefinition implements Definition
+{
+    public function accept(FixtureFactory $fixtureFactory): void
+    {
+        $fixtureFactory->define(Fixture\FixtureFactory\Entity\User::class);
+    }
+}

test/Fixture/Definitions/ImplementsDefinitionButThrowsExceptionDuringConstruction/OrganizationDefinition.php

@@ -0,0 +1,26 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * Copyright (c) 2020 Andreas Möller
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE.md file that was distributed with this source code.
+ *
+ * @see https://github.com/ergebnis/factory-bot
+ */
+
+namespace Ergebnis\FactoryBot\Test\Fixture\Definitions\ImplementsDefinitionButThrowsExceptionDuringConstruction;
+
+use Ergebnis\FactoryBot\Definition;
+use Ergebnis\FactoryBot\FixtureFactory;
+use Ergebnis\FactoryBot\Test\Fixture;
+
+final class OrganizationDefinition implements Definition
+{
+    public function accept(FixtureFactory $fixtureFactory): void
+    {
+        $fixtureFactory->define(Fixture\FixtureFactory\Entity\Organization::class);
+    }
+}

test/Fixture/Definitions/ImplementsDefinitionButThrowsExceptionDuringConstruction/UserDefinition.php

@@ -0,0 +1,26 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * Copyright (c) 2020 Andreas Möller
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE.md file that was distributed with this source code.
+ *
+ * @see https://github.com/ergebnis/factory-bot
+ */
+
+namespace Ergebnis\FactoryBot\Test\Fixture\Definitions\ImplementsDefinitionButThrowsExceptionDuringConstruction;
+
+use Ergebnis\FactoryBot\Definition;
+use Ergebnis\FactoryBot\FixtureFactory;
+use Ergebnis\FactoryBot\Test\Fixture;
+
+final class UserDefinition implements Definition
+{
+    public function accept(FixtureFactory $fixtureFactory): void
+    {
+        $fixtureFactory->define(Fixture\FixtureFactory\Entity\User::class);
+    }
+}

test/Unit/DefinitionsTest.php

@@ -14,6 +14,7 @@
 namespace Ergebnis\FactoryBot\Test\Unit;
 
 use Ergebnis\FactoryBot\Definitions;
+use Ergebnis\FactoryBot\EntityDefinition;
 use Ergebnis\FactoryBot\Exception;
 use Ergebnis\FactoryBot\FixtureFactory;
 use Ergebnis\FactoryBot\Test\Fixture;
@@ -50,7 +51,13 @@ public function testInIgnoresClassesWhichDoNotImplementProviderInterface(): void
 
         $definitions->registerWith($fixtureFactory);
 
-        self::assertSame([], $fixtureFactory->definitions());
+        $registeredDefinitions = $fixtureFactory->definitions();
+
+        self::assertCount(2, $registeredDefinitions);
+        self::assertContainsOnly(EntityDefinition::class, $registeredDefinitions);
+        self::assertArrayHasKey(Fixture\FixtureFactory\Entity\Organization::class, $registeredDefinitions);
+        self::assertArrayNotHasKey(Fixture\FixtureFactory\Entity\Repository::class, $registeredDefinitions);
+        self::assertArrayHasKey(Fixture\FixtureFactory\Entity\User::class, $registeredDefinitions);
     }
 
     public function testInIgnoresDefinitionsThatAreAbstract(): void
@@ -64,7 +71,13 @@ public function testInIgnoresDefinitionsThatAreAbstract(): void
 
         $definitions->registerWith($fixtureFactory);
 
-        self::assertSame([], $fixtureFactory->definitions());
+        $registeredDefinitions = $fixtureFactory->definitions();
+
+        self::assertCount(2, $registeredDefinitions);
+        self::assertContainsOnly(EntityDefinition::class, $registeredDefinitions);
+        self::assertArrayHasKey(Fixture\FixtureFactory\Entity\Organization::class, $registeredDefinitions);
+        self::assertArrayNotHasKey(Fixture\FixtureFactory\Entity\Repository::class, $registeredDefinitions);
+        self::assertArrayHasKey(Fixture\FixtureFactory\Entity\User::class, $registeredDefinitions);
     }
 
     public function testInIgnoresDefinitionsThatHavePrivateConstructors(): void
@@ -78,7 +91,13 @@ public function testInIgnoresDefinitionsThatHavePrivateConstructors(): void
 
         $definitions->registerWith($fixtureFactory);
 
-        self::assertSame([], $fixtureFactory->definitions());
+        $registeredDefinitions = $fixtureFactory->definitions();
+
+        self::assertCount(2, $registeredDefinitions);
+        self::assertContainsOnly(EntityDefinition::class, $registeredDefinitions);
+        self::assertArrayHasKey(Fixture\FixtureFactory\Entity\Organization::class, $registeredDefinitions);
+        self::assertArrayNotHasKey(Fixture\FixtureFactory\Entity\Repository::class, $registeredDefinitions);
+        self::assertArrayHasKey(Fixture\FixtureFactory\Entity\User::class, $registeredDefinitions);
     }
 
     public function testInThrowsInvalidDefinitionExceptionWhenExceptionIsThrownDuringInstantiationOfDefinition(): void
@@ -99,6 +118,12 @@ public function testInAcceptsDefinitionsThatHaveNoIssues(): void
 
         $definitions->registerWith($fixtureFactory);
 
-        self::assertArrayHasKey(Fixture\FixtureFactory\Entity\Repository::class, $fixtureFactory->definitions());
+        $registeredDefinitions = $fixtureFactory->definitions();
+
+        self::assertCount(3, $registeredDefinitions);
+        self::assertContainsOnly(EntityDefinition::class, $registeredDefinitions);
+        self::assertArrayHasKey(Fixture\FixtureFactory\Entity\Organization::class, $registeredDefinitions);
+        self::assertArrayHasKey(Fixture\FixtureFactory\Entity\Repository::class, $registeredDefinitions);
+        self::assertArrayHasKey(Fixture\FixtureFactory\Entity\User::class, $registeredDefinitions);
     }
 }