Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Throw InvalidDefinition exception when concrete definition can not be instantiated #301

Merged
merged 1 commit into from
Jul 12, 2020

Conversation

localheinz
Copy link
Member

This PR

  • throws an InvalidDefinition exception when a concrete definition can not be instantiated

@localheinz localheinz self-assigned this Jul 12, 2020
@codecov
Copy link

codecov bot commented Jul 12, 2020

Codecov Report

Merging #301 into main will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #301      +/-   ##
============================================
+ Coverage     98.54%   98.56%   +0.02%     
- Complexity      100      102       +2     
============================================
  Files            23       23              
  Lines           274      279       +5     
============================================
+ Hits            270      275       +5     
  Misses            4        4              
Impacted Files Coverage Δ Complexity Δ
src/Definitions.php 92.30% <100.00%> (+0.64%) 11.00 <0.00> (+1.00)
src/Exception/InvalidDefinition.php 100.00% <100.00%> (ø) 2.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 082248b...169c6a9. Read the comment docs.

@ergebnis-bot ergebnis-bot self-requested a review July 12, 2020 14:55
@ergebnis-bot ergebnis-bot self-assigned this Jul 12, 2020
@ergebnis-bot ergebnis-bot merged commit 5c029f9 into main Jul 12, 2020
@ergebnis-bot ergebnis-bot deleted the fix/throw branch July 12, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants