Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: No need to import faker #318

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Fix: No need to import faker #318

merged 1 commit into from
Jul 14, 2020

Conversation

localheinz
Copy link
Member

This PR

  • stops importing $faker

@localheinz localheinz self-assigned this Jul 14, 2020
@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #318 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #318   +/-   ##
=========================================
  Coverage     98.93%   98.93%           
  Complexity      101      101           
=========================================
  Files            22       22           
  Lines           283      283           
=========================================
  Hits            280      280           
  Misses            3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef506fa...86d9b8c. Read the comment docs.

@ergebnis-bot ergebnis-bot self-requested a review July 14, 2020 20:57
@ergebnis-bot ergebnis-bot self-assigned this Jul 14, 2020
@ergebnis-bot ergebnis-bot merged commit 833f4ca into main Jul 14, 2020
@ergebnis-bot ergebnis-bot deleted the fix/import branch July 14, 2020 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants