Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Signature of closure #361

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Fix: Signature of closure #361

merged 1 commit into from
Aug 4, 2020

Conversation

localheinz
Copy link
Member

This PR

  • fixes the signatures of closures used in optional field definitions that are not invoked in tests

@localheinz localheinz self-assigned this Aug 4, 2020
@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #361 into main will increase coverage by 0.54%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #361      +/-   ##
============================================
+ Coverage     98.41%   98.95%   +0.54%     
- Complexity       98      102       +4     
============================================
  Files            21       23       +2     
  Lines           252      288      +36     
============================================
+ Hits            248      285      +37     
+ Misses            4        3       -1     
Impacted Files Coverage Δ Complexity Δ
src/FieldDefinition/Reference.php 100.00% <ø> (ø) 2.00 <0.00> (ø)
src/Count.php 100.00% <100.00%> (ø) 8.00 <8.00> (?)
src/Exception/InvalidCount.php 100.00% <100.00%> (ø) 1.00 <1.00> (?)
src/Exception/InvalidDefinition.php 100.00% <100.00%> (ø) 3.00 <3.00> (+2.00)
src/Exception/InvalidMaximum.php 100.00% <100.00%> (ø) 1.00 <1.00> (?)
src/Exception/InvalidMinimum.php 100.00% <100.00%> (ø) 1.00 <1.00> (?)
src/FieldDefinition.php 100.00% <100.00%> (ø) 9.00 <1.00> (-2.00)
src/FieldDefinition/References.php 100.00% <100.00%> (ø) 2.00 <1.00> (ø)
src/FixtureFactory.php 97.82% <100.00%> (-0.41%) 45.00 <19.00> (+3.00) ⬇️
src/Strategy/DefaultStrategy.php 100.00% <100.00%> (ø) 4.00 <4.00> (?)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67dab4e...1667c7c. Read the comment docs.

@ergebnis-bot ergebnis-bot self-requested a review August 4, 2020 14:43
@ergebnis-bot ergebnis-bot self-assigned this Aug 4, 2020
@ergebnis-bot ergebnis-bot merged commit afd0815 into main Aug 4, 2020
@ergebnis-bot ergebnis-bot deleted the fix/signature branch August 4, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants