Fix: Add tests

phpstan-baseline.neon

@@ -115,6 +115,26 @@ parameters:
 			count: 1
 			path: test/Double/Faker/FalseGenerator.php
 
+		-
+			message: "#^Method Ergebnis\\\\FactoryBot\\\\Test\\\\Double\\\\Faker\\\\MaximumGenerator\\:\\:numberBetween\\(\\) has parameter \\$max with no typehint specified\\.$#"
+			count: 1
+			path: test/Double/Faker/MaximumGenerator.php
+
+		-
+			message: "#^Method Ergebnis\\\\FactoryBot\\\\Test\\\\Double\\\\Faker\\\\MaximumGenerator\\:\\:numberBetween\\(\\) has parameter \\$min with no typehint specified\\.$#"
+			count: 1
+			path: test/Double/Faker/MaximumGenerator.php
+
+		-
+			message: "#^Method Ergebnis\\\\FactoryBot\\\\Test\\\\Double\\\\Faker\\\\MinimumGenerator\\:\\:numberBetween\\(\\) has parameter \\$max with no typehint specified\\.$#"
+			count: 1
+			path: test/Double/Faker/MinimumGenerator.php
+
+		-
+			message: "#^Method Ergebnis\\\\FactoryBot\\\\Test\\\\Double\\\\Faker\\\\MinimumGenerator\\:\\:numberBetween\\(\\) has parameter \\$min with no typehint specified\\.$#"
+			count: 1
+			path: test/Double/Faker/MinimumGenerator.php
+
 		-
 			message: "#^Method Ergebnis\\\\FactoryBot\\\\Test\\\\Double\\\\Faker\\\\TrueGenerator\\:\\:boolean\\(\\) has parameter \\$chanceOfGettingTrue with no typehint specified\\.$#"
 			count: 1

psalm-baseline.xml

@@ -40,6 +40,30 @@
       <code>$max</code>
     </MixedArgument>
   </file>
+  <file src="test/Double/Faker/MaximumGenerator.php">
+    <MissingParamType occurrences="2">
+      <code>$min</code>
+      <code>$max</code>
+    </MissingParamType>
+    <MixedInferredReturnType occurrences="1">
+      <code>int</code>
+    </MixedInferredReturnType>
+    <MixedReturnStatement occurrences="1">
+      <code>$max</code>
+    </MixedReturnStatement>
+  </file>
+  <file src="test/Double/Faker/MinimumGenerator.php">
+    <MissingParamType occurrences="2">
+      <code>$min</code>
+      <code>$max</code>
+    </MissingParamType>
+    <MixedInferredReturnType occurrences="1">
+      <code>int</code>
+    </MixedInferredReturnType>
+    <MixedReturnStatement occurrences="1">
+      <code>$min</code>
+    </MixedReturnStatement>
+  </file>
   <file src="test/Double/Faker/TrueGenerator.php">
     <MissingParamType occurrences="3">
       <code>$chanceOfGettingTrue</code>

test/Double/Faker/MaximumGenerator.php

@@ -0,0 +1,24 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * Copyright (c) 2020 Andreas Möller
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE.md file that was distributed with this source code.
+ *
+ * @see https://github.com/ergebnis/factory-bot
+ */
+
+namespace Ergebnis\FactoryBot\Test\Double\Faker;
+
+use Faker\Generator;
+
+final class MaximumGenerator extends Generator
+{
+    public function numberBetween($min = 0, $max = 2147483647): int
+    {
+        return $max;
+    }
+}

test/Double/Faker/MinimumGenerator.php

@@ -0,0 +1,24 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * Copyright (c) 2020 Andreas Möller
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE.md file that was distributed with this source code.
+ *
+ * @see https://github.com/ergebnis/factory-bot
+ */
+
+namespace Ergebnis\FactoryBot\Test\Double\Faker;
+
+use Faker\Generator;
+
+final class MinimumGenerator extends Generator
+{
+    public function numberBetween($min = 0, $max = 2147483647): int
+    {
+        return $min;
+    }
+}

test/Unit/Strategy/DefaultStrategyTest.php

@@ -152,6 +152,50 @@ public function testResolveCountResolvesCountWithFakerWhenCountIsExact(): void
         self::assertSame($value, $resolved);
     }
 
+    /**
+     * @dataProvider \Ergebnis\FactoryBot\Test\DataProvider\IntProvider::greaterThanOrEqualToZero()
+     *
+     * @param int $minimum
+     */
+    public function testResolveCountResolvesCountWithFakerWhenCountIsBetweenAndFakerReturnsMinimum(int $minimum): void
+    {
+        $maximum = self::faker()->numberBetween($minimum + 1);
+
+        $strategy = new DefaultStrategy();
+
+        $resolved = $strategy->resolveCount(
+            new Double\Faker\MinimumGenerator(),
+            Count::between(
+                $minimum,
+                $maximum
+            )
+        );
+
+        self::assertSame($minimum, $resolved);
+    }
+
+    /**
+     * @dataProvider \Ergebnis\FactoryBot\Test\DataProvider\IntProvider::greaterThanZero()
+     *
+     * @param int $maximum
+     */
+    public function testResolveCountResolvesCountWithFakerWhenCountIsBetweenAndFakerReturnsMaximum(int $maximum): void
+    {
+        $minimum = self::faker()->numberBetween(0, $maximum - 1);
+
+        $strategy = new DefaultStrategy();
+
+        $resolved = $strategy->resolveCount(
+            new Double\Faker\MaximumGenerator(),
+            Count::between(
+                $minimum,
+                $maximum
+            )
+        );
+
+        self::assertSame($maximum, $resolved);
+    }
+
     public function testResolveCountResolvesCountWithFakerWhenCountIsBetween(): void
     {
         $faker = self::faker();