Fix: Add property type declarations #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
commented
Dec 27, 2021
| @@ -25,7 +25,7 @@ public function accept(FactoryBot\FixtureFactory $fixtureFactory): void | |||
| 'id' => FactoryBot\FieldDefinition::closure(static function (Generator $faker): string { | |||
| return $faker->uuid; | |||
| }), | |||
| 'isVerified' => FactoryBot\FieldDefinition::optionalClosure(static function (Generator $faker): bool { | |||
| 'isVerified' => FactoryBot\FieldDefinition::closure(static function (Generator $faker): bool { | |||
There was a problem hiding this comment.
Field is not nullable.
Codecov Report
@@ Coverage Diff @@
## main #697 +/- ##
=========================================
Coverage 98.50% 98.50%
Complexity 103 103
=========================================
Files 25 25
Lines 335 335
=========================================
Hits 330 330
Misses 5 5
Continue to review full report at Codecov.
|
1 task
localheinz
force-pushed
the
fix/property
branch
from
0eacdf9
to
13caad0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request