Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Avoid use of isset() #74

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Fix: Avoid use of isset() #74

merged 1 commit into from
Mar 23, 2020

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Mar 23, 2020

This PR

  • avoids the use of isset()

Follows #1.

@localheinz localheinz added the bug label Mar 23, 2020
@localheinz localheinz self-assigned this Mar 23, 2020
@localheinz localheinz marked this pull request as ready for review March 23, 2020 19:03
@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #74 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #74   +/-   ##
=========================================
  Coverage     93.40%   93.40%           
  Complexity       77       77           
=========================================
  Files             8        8           
  Lines           197      197           
=========================================
  Hits            184      184           
  Misses           13       13           
Impacted Files Coverage Δ Complexity Δ
src/EntityDef.php 94.73% <100.00%> (ø) 14.00 <0.00> (ø)
src/FixtureFactory.php 91.11% <100.00%> (ø) 37.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f10354...168a715. Read the comment docs.

@localheinz localheinz merged commit 581abf8 into master Mar 23, 2020
@localheinz localheinz deleted the fix/isset branch March 23, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant