Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Avoid use of empty() #84

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Fix: Avoid use of empty() #84

merged 1 commit into from
Mar 26, 2020

Conversation

localheinz
Copy link
Member

This PR

  • avoids use of empty()

Follows #1.

@localheinz localheinz added the bug label Mar 26, 2020
@localheinz localheinz self-assigned this Mar 26, 2020
@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #84 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #84   +/-   ##
=========================================
  Coverage     93.50%   93.50%           
  Complexity       75       75           
=========================================
  Files             8        8           
  Lines           200      200           
=========================================
  Hits            187      187           
  Misses           13       13           
Impacted Files Coverage Δ Complexity Δ
src/FixtureFactory.php 90.69% <100.00%> (ø) 36.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4190aed...d33de8f. Read the comment docs.

@localheinz localheinz merged commit 76a5d3c into master Mar 26, 2020
@localheinz localheinz deleted the fix/empty branch March 26, 2020 08:29
@localheinz localheinz restored the fix/empty branch March 26, 2020 10:01
@localheinz localheinz deleted the fix/empty branch March 28, 2020 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant