Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add type and return type declarations #93

Merged
merged 1 commit into from
Mar 28, 2020
Merged

Fix: Add type and return type declarations #93

merged 1 commit into from
Mar 28, 2020

Conversation

localheinz
Copy link
Member

This PR

  • adds type and return type declarations to FieldDefinition

Follows #1.

@localheinz localheinz added the bug label Mar 28, 2020
@localheinz localheinz self-assigned this Mar 28, 2020
@codecov
Copy link

codecov bot commented Mar 28, 2020

Codecov Report

Merging #93 into master will not change coverage by %.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #93   +/-   ##
=========================================
  Coverage     93.77%   93.77%           
  Complexity       77       77           
=========================================
  Files             9        9           
  Lines           209      209           
=========================================
  Hits            196      196           
  Misses           13       13           
Impacted Files Coverage Δ Complexity Δ
src/FixtureFactory.php 90.80% <88.88%> (ø) 36.00 <30.00> (ø)
src/EntityDefinition.php 95.45% <100.00%> (ø) 13.00 <7.00> (ø)
src/FieldDefinition.php 95.65% <100.00%> (ø) 6.00 <6.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d02aa9...90f5326. Read the comment docs.

@localheinz localheinz force-pushed the fix/type branch 5 times, most recently from c7e6ddc to c446ad5 Compare March 28, 2020 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant