Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Throw CanNotResolve instead of ResolvedToRootSchema when JSON pointer is invalid #202

Merged
merged 1 commit into from
Jan 30, 2022

Conversation

localheinz
Copy link
Member

This pull request

  • throws a CanNotResolve exception instead of a ResolvedToRootSchema exception when a JSON pointer is not a valid URI fragment identifier

@localheinz localheinz self-assigned this Jan 30, 2022
@codecov
Copy link

codecov bot commented Jan 30, 2022

Codecov Report

Merging #202 (b655a16) into main (e05587c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #202   +/-   ##
=========================================
  Coverage     99.13%   99.13%           
  Complexity       35       35           
=========================================
  Files            12       12           
  Lines           116      116           
=========================================
  Hits            115      115           
  Misses            1        1           
Impacted Files Coverage Δ
src/SchemaValidator.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e05587c...b655a16. Read the comment docs.

@localheinz localheinz force-pushed the fix/can-not-resolve branch 7 times, most recently from 9a16189 to 6b07223 Compare January 30, 2022 11:48
@localheinz localheinz merged commit 2650503 into main Jan 30, 2022
@localheinz localheinz deleted the fix/can-not-resolve branch January 30, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants