Fix: Remove get_called_class and get_class options from functions opt…

…ion of function_to_constant fixer
ergebnis · Oct 21, 2023 · 8ab698b · 8ab698b
1 parent ae2767a
commit 8ab698b
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,10 @@ For a full diff see [`6.8.1...main`][6.8.1...main].
 
 - Configured `case` option of `elements` option of `class_attributes_separation` fixer ([#922]), by [@localheinz]
 
+### Fixed
+
+- Removed `get_called_class` and `get_class` options from `functions` option of `function_to_constant` fixer where the resulting code would be incompatible with the target PHP version ([#923]), by [@localheinz]
+
 ## [`6.8.1`][6.8.1]
 
 For a full diff see [`6.8.0...6.8.1`][6.8.0...6.8.1].

diff --git a/src/RuleSet/Php53.php b/src/RuleSet/Php53.php
@@ -224,8 +224,6 @@ public static function create(): RuleSet
                 ],
                 'function_to_constant' => [
                     'functions' => [
-                        'get_called_class',
-                        'get_class',
                         'php_sapi_name',
                         'phpversion',
                         'pi',

diff --git a/src/RuleSet/Php54.php b/src/RuleSet/Php54.php
@@ -225,8 +225,6 @@ public static function create(): RuleSet
                 ],
                 'function_to_constant' => [
                     'functions' => [
-                        'get_called_class',
-                        'get_class',
                         'php_sapi_name',
                         'phpversion',
                         'pi',

diff --git a/test/Unit/RuleSet/Php53Test.php b/test/Unit/RuleSet/Php53Test.php
@@ -246,8 +246,6 @@ protected function expectedRules(): Rules
             ],
             'function_to_constant' => [
                 'functions' => [
-                    'get_called_class',
-                    'get_class',
                     'php_sapi_name',
                     'phpversion',
                     'pi',

diff --git a/test/Unit/RuleSet/Php54Test.php b/test/Unit/RuleSet/Php54Test.php
@@ -247,8 +247,6 @@ protected function expectedRules(): Rules
             ],
             'function_to_constant' => [
                 'functions' => [
-                    'get_called_class',
-                    'get_class',
                     'php_sapi_name',
                     'phpversion',
                     'pi',