Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove $targetPhpVersion field and targetPhpVersion() method #866

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Sep 15, 2023

This pull request

  • removes the $targetPhpVersion field and targetPhpVersion() method from AbstractRuleSet

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #866 (0da5ec9) into main (7bbd6d1) will decrease coverage by 3.13%.
The diff coverage is 92.59%.

❗ Current head 0da5ec9 differs from pull request most recent head 545b7ed. Consider uploading reports for the commit 545b7ed to get more accurate results

@@              Coverage Diff              @@
##                main     #866      +/-   ##
=============================================
- Coverage     100.00%   96.87%   -3.13%     
- Complexity         7       18      +11     
=============================================
  Files              2       14      +12     
  Lines             41       64      +23     
=============================================
+ Hits              41       62      +21     
- Misses             0        2       +2     
Files Changed Coverage Δ
src/RuleSet/Php82.php 0.00% <0.00%> (ø)
src/RuleSet/AbstractRuleSet.php 100.00% <100.00%> (ø)
src/RuleSet/Php53.php 100.00% <100.00%> (ø)
src/RuleSet/Php54.php 100.00% <100.00%> (ø)
src/RuleSet/Php55.php 100.00% <100.00%> (ø)
src/RuleSet/Php56.php 100.00% <100.00%> (ø)
src/RuleSet/Php70.php 100.00% <100.00%> (ø)
src/RuleSet/Php71.php 100.00% <100.00%> (ø)
src/RuleSet/Php72.php 100.00% <100.00%> (ø)
src/RuleSet/Php73.php 100.00% <100.00%> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@localheinz localheinz changed the title Fix: Remove $targetPhpVersion field Fix: Remove $targetPhpVersion field and targetPhpVersion() method Sep 15, 2023
@localheinz localheinz force-pushed the fix/target-php-version branch 3 times, most recently from 7f164c1 to 0da5ec9 Compare September 15, 2023 10:00
@localheinz localheinz merged commit e3863e1 into main Sep 15, 2023
13 checks passed
@localheinz localheinz deleted the fix/target-php-version branch September 15, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants