Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove rules() method from AbstractRuleSet #868

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Conversation

localheinz
Copy link
Member

This pull request

  • removes the rules() method from AbstractRuleSet

@localheinz localheinz self-assigned this Sep 15, 2023
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #868 (27cb11f) into main (4326f24) will decrease coverage by 0.84%.
The diff coverage is 91.66%.

@@             Coverage Diff              @@
##               main     #868      +/-   ##
============================================
- Coverage     94.52%   93.68%   -0.84%     
- Complexity       29       40      +11     
============================================
  Files            14       14              
  Lines            73       95      +22     
============================================
+ Hits             69       89      +20     
- Misses            4        6       +2     
Files Changed Coverage Δ
src/RuleSet/AbstractRuleSet.php 100.00% <ø> (ø)
src/RuleSet/Php82.php 0.00% <0.00%> (ø)
src/RuleSet/Php53.php 100.00% <100.00%> (ø)
src/RuleSet/Php54.php 100.00% <100.00%> (ø)
src/RuleSet/Php55.php 100.00% <100.00%> (ø)
src/RuleSet/Php56.php 100.00% <100.00%> (ø)
src/RuleSet/Php70.php 100.00% <100.00%> (ø)
src/RuleSet/Php71.php 100.00% <100.00%> (ø)
src/RuleSet/Php72.php 100.00% <100.00%> (ø)
src/RuleSet/Php73.php 100.00% <100.00%> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@localheinz localheinz merged commit 5ffaabf into main Sep 15, 2023
@localheinz localheinz deleted the fix/rules branch September 15, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants