Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Extract PhpVersion as value object #871

Merged
merged 1 commit into from
Sep 16, 2023

Conversation

localheinz
Copy link
Member

This pull request

  • extracts PhpVersion as a value object

@localheinz localheinz self-assigned this Sep 16, 2023
@localheinz localheinz marked this pull request as ready for review September 16, 2023 09:24
@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Merging #871 (5082fd1) into main (5a49af4) will increase coverage by 1.88%.
The diff coverage is 96.33%.

@@             Coverage Diff              @@
##               main     #871      +/-   ##
============================================
+ Coverage     94.17%   96.06%   +1.88%     
- Complexity       44       70      +26     
============================================
  Files            15       19       +4     
  Lines           103      254     +151     
============================================
+ Hits             97      244     +147     
- Misses            6       10       +4     
Files Changed Coverage Δ
src/RuleSet/Php82.php 0.00% <0.00%> (ø)
src/Factory.php 100.00% <100.00%> (ø)
src/Name.php 100.00% <100.00%> (ø)
src/PhpVersion.php 100.00% <100.00%> (ø)
src/PhpVersion/Major.php 100.00% <100.00%> (ø)
src/PhpVersion/Minor.php 100.00% <100.00%> (ø)
src/PhpVersion/Patch.php 100.00% <100.00%> (ø)
src/RuleSet/Php53.php 100.00% <100.00%> (ø)
src/RuleSet/Php54.php 100.00% <100.00%> (ø)
src/RuleSet/Php55.php 100.00% <100.00%> (ø)
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@localheinz localheinz changed the title Enhancement: Extract PhpVersion as value object Enhancement: Extract PhpVersion as value object Sep 16, 2023
@localheinz localheinz merged commit 3414639 into main Sep 16, 2023
16 checks passed
@localheinz localheinz deleted the feature/php-version branch September 16, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants