Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Extract Config\Rules as a value object #874

Merged
merged 1 commit into from
Sep 17, 2023
Merged

Conversation

localheinz
Copy link
Member

This pull request

  • extracts Config\Rules as a value object

@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Merging #874 (e44e178) into main (e2825e9) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##                main      #874   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity        82        87    +5     
===========================================
  Files             19        20    +1     
  Lines            279       289   +10     
===========================================
+ Hits             279       289   +10     
Files Changed Coverage Δ
src/Factory.php 100.00% <100.00%> (ø)
src/RuleSet/Php53.php 100.00% <100.00%> (ø)
src/RuleSet/Php54.php 100.00% <100.00%> (ø)
src/RuleSet/Php55.php 100.00% <100.00%> (ø)
src/RuleSet/Php56.php 100.00% <100.00%> (ø)
src/RuleSet/Php70.php 100.00% <100.00%> (ø)
src/RuleSet/Php71.php 100.00% <100.00%> (ø)
src/RuleSet/Php72.php 100.00% <100.00%> (ø)
src/RuleSet/Php73.php 100.00% <100.00%> (ø)
src/RuleSet/Php74.php 100.00% <100.00%> (ø)
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@localheinz localheinz marked this pull request as ready for review September 16, 2023 16:27
@localheinz localheinz merged commit cad932a into main Sep 17, 2023
15 checks passed
@localheinz localheinz deleted the feature/rules branch September 17, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants