Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#[Before] attribute should not be private in final classes #863

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

#[Before] attribute should not be private in final classes #863

wants to merge 2 commits into from
+30 −0

Conversation

cosmastech
Copy link

@cosmastech cosmastech commented Nov 17, 2024 •
edited
Loading

This pull request

  • Allows #[Before] to remain protected
  • Adds test

Follows #.
Related to #.
Fixes #845

@cosmastech
Copy link
Author

Appreciate some guidance on if you want to follow something similar to how NoExtendsRule receives an array of class strings, or if there's something else I should do.

thanks for the plugin!

@cosmastech cosmastech marked this pull request as ready for review November 17, 2024 13:47
@cosmastech cosmastech changed the title #[Before] attribute should not be final #[Before] attribute should not be private in final classes Nov 17, 2024
@localheinz localheinz self-assigned this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ergebnis-bot ergebnis-bot Awaiting requested review from ergebnis-bot ergebnis-bot is a code owner

@localheinz localheinz Awaiting requested review from localheinz localheinz is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@localheinz localheinz

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PrivateInFinalClassRule throws false positive when using PHPUnit attribute #[Before]
2 participants
@cosmastech @localheinz