Merge pull request #112 from ergebnis/fix/method

Fix: Use methods instead of deprecated magic properties
ergebnis · Nov 28, 2021 · e182689 · e182689
2 parents 679974a + e8226e3
commit e182689
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 22 deletions.
diff --git a/psalm-baseline.xml b/psalm-baseline.xml
@@ -51,9 +51,6 @@
     </PropertyNotSetInConstructor>
   </file>
   <file src="test/Unit/Console/ColorTest.php">
-    <DeprecatedMethod occurrences="1">
-      <code>sentence</code>
-    </DeprecatedMethod>
     <MixedArgument occurrences="1">
       <code>$output</code>
     </MixedArgument>
@@ -102,12 +99,9 @@
     </PropertyNotSetInConstructor>
   </file>
   <file src="test/Unit/SlowTestTest.php">
-    <DeprecatedMethod occurrences="1">
-      <code>word</code>
-    </DeprecatedMethod>
     <MixedArgument occurrences="2">
-      <code>$faker-&gt;word</code>
-      <code>$faker-&gt;word</code>
+      <code>$faker-&gt;word()</code>
+      <code>$faker-&gt;word()</code>
     </MixedArgument>
     <PropertyNotSetInConstructor occurrences="2">
       <code>SlowTestTest</code>
@@ -127,15 +121,10 @@
     </PropertyNotSetInConstructor>
   </file>
   <file src="test/Unit/Subscriber/TestSuiteFinishedSubscriberTest.php">
-    <DeprecatedMethod occurrences="3">
-      <code>word</code>
-      <code>word</code>
-      <code>word</code>
-    </DeprecatedMethod>
     <MixedArgument occurrences="3">
-      <code>$faker-&gt;word</code>
-      <code>$faker-&gt;word</code>
-      <code>$faker-&gt;word</code>
+      <code>$faker-&gt;word()</code>
+      <code>$faker-&gt;word()</code>
+      <code>$faker-&gt;word()</code>
     </MixedArgument>
     <PropertyNotSetInConstructor occurrences="2">
       <code>TestSuiteFinishedSubscriberTest</code>

diff --git a/test/Unit/Console/ColorTest.php b/test/Unit/Console/ColorTest.php
@@ -37,7 +37,7 @@ public function testDimReturnsOriginalStringWhenItIsWhitespaceOnly(string $outpu
 
     public function testDimReturnsDimmedStringWhenItIsNotWhitespaceOnly(): void
     {
-        $output = self::faker()->sentence;
+        $output = self::faker()->sentence();
 
         $expected = <<<TXT
 \e[2m{$output}\e[22m

diff --git a/test/Unit/SlowTestTest.php b/test/Unit/SlowTestTest.php
@@ -33,8 +33,8 @@ public function testFromTestDurationAndMaximumDurationReturnsSlowTest(): void
 
         $test = new Event\Code\Test(
             self::class,
-            $faker->word,
-            $faker->word,
+            $faker->word(),
+            $faker->word(),
         );
 
         $duration = Event\Telemetry\Duration::fromSecondsAndNanoseconds(

diff --git a/test/Unit/Subscriber/TestSuiteFinishedSubscriberTest.php b/test/Unit/Subscriber/TestSuiteFinishedSubscriberTest.php
@@ -55,7 +55,7 @@ public function testNotifyDoesNothingWhenCollectorHasNotCollectedAnything(): voi
                 ),
                 Event\Telemetry\MemoryUsage::fromBytes($faker->numberBetween()),
             ),
-            $faker->word,
+            $faker->word(),
             new Event\TestSuite\Result(
                 $faker->numberBetween(),
                 new Event\TestSuite\FailureCollection(),
@@ -157,7 +157,7 @@ public function testNotifyDoesNothingWhenReporterHasNotReportedAnything(): void
                 ),
                 Event\Telemetry\MemoryUsage::fromBytes($faker->numberBetween()),
             ),
-            $faker->word,
+            $faker->word(),
             new Event\TestSuite\Result(
                 $faker->numberBetween(),
                 new Event\TestSuite\FailureCollection(),
@@ -265,7 +265,7 @@ public function testNotifyEchosReportWhenReporterHasReportedSomething(): void
                 ),
                 Event\Telemetry\MemoryUsage::fromBytes($faker->numberBetween()),
             ),
-            $faker->word,
+            $faker->word(),
             new Event\TestSuite\Result(
                 $faker->numberBetween(),
                 new Event\TestSuite\FailureCollection(),