Enhancement: Allow creating Major, Minor, and Patch from int
#10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 47 59 +12
===========================================
Files 12 12
Lines 119 152 +33
===========================================
+ Hits 119 152 +33 ☔ View full report in Codecov by Sentry. |
localheinz
commented
Dec 25, 2023
| @@ -34,14 +46,19 @@ public static function fromString(string $value): self | |||
| throw Exception\InvalidMajor::fromString($value); | |||
| } | |||
|
|
|||
| return new self($value); | |||
| return new self((int) $value); | |||
There was a problem hiding this comment.
Looks like this can be a problem when $value is greater than PHP_INT_MAX.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request
Major,Minor, andPatchfromintRelated to #7.