[18566] - add custom ergon changes to plugin #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `allowsInlineMediaPlayback` to `WKWebViewConfiguration` to allow media to play inline. This fixed the camera overlay issues when the camera is opened within the webview.
Replace existing done button with a close button ('X' icon) in WKWebViewController. Introduce a new method to handle the close action by dismissing the web view.
Add logic to set the status bar background color to white when WKWebViewController appears, and remove it when the view disappears. This ensures a consistent appearance of the status bar with the underlying app theme.
This update modifies the InAppBrowserPlugin to set the navigation bar tint color to white. This ensures that the appearance of the navigation bar matches the underlying app theme (white).
This change removes the shadow effect by setting the elevation to 0dp for the AppBarLayout in the browser activity layout. Removes the unwanted line (shadow) between the AppBarLayout and the content underneath.
Changed the close button alignment from start to end and added right padding. Ensures that the position of the close button is at the same position as our close buttons in the app.
Updated the WebViewDialog to use setStatusBarColor and setNavigationBarColor instead of setting the window to fullscreen. This changes the UI to have a white status bar and a light grey navigation bar (at very bottom).
Set the WebView background color to white for better visual consistency. This change ensures that the WebView has a default white background.
# Conflicts: # android/src/main/java/ee/forgr/capacitor_inappbrowser/WebViewDialog.java # ios/Plugin/WKWebViewController.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.