Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flake linter, fix linter issues #3

Merged
merged 1 commit into from
Sep 27, 2022
Merged

add flake linter, fix linter issues #3

merged 1 commit into from
Sep 27, 2022

Conversation

totlsota
Copy link
Contributor

I checked out the client and was going to lint it.There was a short journey to get there:

First any poetry action was I was giving a runtime error:

  RuntimeError

  The Poetry configuration is invalid:
    - Additional properties are not allowed ('group' was unexpected)

As reported here, poetry version > 1.2.x is required for certain features. Added comment to README.md.


Second, the current live poetry install script fails to update and poetry self update fails as per here

remove like this:

curl -sSL https://raw.githubusercontent.com/python-poetry/poetry/master/get-poetry.py | python3 - --uninstall

install like this:

curl -sSL https://install.python-poetry.org | python3 - --git https://github.com/python-poetry/poetry.git@master

check version is > 1.2x poetry --version


Finally, added the flake8 linter, corrected the linter issues

@benedictbrady benedictbrady merged commit 0ca451d into devel Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants