Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ProveDlog with ECPoint in box wrapper methods/box candidate m… #248

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Replace ProveDlog with ECPoint in box wrapper methods/box candidate m… #248

merged 1 commit into from
Apr 3, 2023

Conversation

SethDusek
Copy link
Collaborator

For #81

Ran into some strange issues while rebasing with the previous PR.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4576302116

  • 12 of 16 (75.0%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 59.871%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/cli_commands/transfer_oracle_token.rs 1 2 50.0%
core/src/pool_commands.rs 0 1 0.0%
core/src/main.rs 0 2 0.0%
Totals Coverage Status
Change from base Build 4481622843: -0.02%
Covered Lines: 2038
Relevant Lines: 3404
💛 - Coveralls

@SethDusek SethDusek marked this pull request as ready for review April 2, 2023 10:09
greenhat
greenhat approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@greenhat greenhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Thank you!

@greenhat greenhat merged commit 60c34ca into ergoplatform:develop Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greenhat greenhat greenhat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SethDusek @coveralls @greenhat