Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action report to keep results from actions for monitoring an REST API #271

Merged
merged 7 commits into from
May 17, 2023

Conversation

greenhat
Copy link
Member

@greenhat greenhat commented May 16, 2023

Close #262

This PR introduces *ActionReport types created during the refresh and datapoint actions. Along with storage and access across all app modules (REST API now, health monitoring later).

draft refresh generation;
@coveralls
Copy link

coveralls commented May 16, 2023

Pull Request Test Coverage Report for Build 5001140377

  • 4 of 34 (11.76%) changed or added relevant lines in 6 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.3%) to 59.8%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/pool_commands.rs 0 3 0.0%
core/src/action_report.rs 0 7 0.0%
core/src/main.rs 0 8 0.0%
core/src/api.rs 0 12 0.0%
Files with Coverage Reduction New Missed Lines %
core/src/api.rs 1 0%
core/src/main.rs 1 0%
Totals Coverage Status
Change from base Build 4978549204: -0.3%
Covered Lines: 2096
Relevant Lines: 3505

💛 - Coveralls

@greenhat greenhat force-pushed the i262-poolstatus-oracle-count branch from 8c6da05 to f196ba6 Compare May 17, 2023 06:13
@greenhat greenhat marked this pull request as ready for review May 17, 2023 08:55
@greenhat greenhat changed the title Fix oracle count in /poolStatus REST API endpoint Add action report to keep results from actions for monitoring purposes May 17, 2023
@greenhat greenhat changed the title Add action report to keep results from actions for monitoring purposes Add action report to keep results from actions for monitoring an REST API May 17, 2023
@greenhat greenhat merged commit d61c47e into develop May 17, 2023
@greenhat greenhat deleted the i262-poolstatus-oracle-count branch May 17, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants