Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tx fee estimation #128

Merged
merged 4 commits into from
Oct 30, 2020
Merged

Tx fee estimation #128

merged 4 commits into from
Oct 30, 2020

Conversation

greenhat
Copy link
Member

@greenhat greenhat commented Oct 28, 2020 •
edited
Loading

Close #94

New features:

  • TxBuilder::estimate_tx_size_bytes() to get estimated serialized transaction size in bytes after signing (assuming P2PK box spending);
  • tx_builder::SUGGESTED_TX_FEE constant with "default" current tx fee used lately (1100000 nanoERGs);

@coveralls
Copy link

coveralls commented Oct 28, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 831

  • 34 of 36 (94.44%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 86.94%
Changes Missing Coverage Covered Lines Changed/Added Lines %
ergo-lib/src/wallet/tx_builder.rs 30 32 93.75%
Totals Coverage Status
Change from base Build 823: 0.1%
Covered Lines: 2350
Relevant Lines: 2703
💛 - Coveralls

@greenhat greenhat marked this pull request as ready for review October 28, 2020 15:10
@greenhat greenhat merged commit 3471415 into develop Oct 30, 2020
@greenhat greenhat deleted the i94-tx-fee-est branch October 30, 2020 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tx fee estimation to TxBuilder
2 participants
@greenhat @coveralls