Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DHT variant and JSON encoding for SecretKey; #665

Merged
merged 5 commits into from
Dec 28, 2022

Conversation

greenhat
Copy link
Member

@greenhat greenhat commented Dec 27, 2022

Close #664

@coveralls
Copy link

coveralls commented Dec 27, 2022

Pull Request Test Coverage Report for Build 3793592757

  • 44 of 53 (83.02%) changed or added relevant lines in 2 files are covered.
  • 28 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.2%) to 82.834%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ergo-lib/src/wallet/secret_key.rs 19 28 67.86%
Files with Coverage Reduction New Missed Lines %
ergo-lib/src/wallet/secret_key.rs 2 71.05%
ergo-merkle-tree/src/merkletree.rs 2 97.39%
ergo-rest/src/api/peer_discovery_internals/non_chrome.rs 2 72.52%
ergo-merkle-tree/src/batchmerkleproof.rs 3 90.48%
ergotree-ir/src/chain/token.rs 5 72.58%
ergotree-ir/src/serialization/types.rs 14 80.07%
Totals Coverage Status
Change from base Build 3766480790: -0.2%
Covered Lines: 9892
Relevant Lines: 11942

💛 - Coveralls

@greenhat greenhat force-pushed the i664-dht-secret-key branch from 405f450 to a007baf Compare December 28, 2022 10:59
@greenhat greenhat marked this pull request as ready for review December 28, 2022 11:14
@greenhat greenhat merged commit b1897e3 into develop Dec 28, 2022
@greenhat greenhat deleted the i664-dht-secret-key branch December 28, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add public API for Diffie-Hellman Tuples transaction signing
2 participants