Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate parsed ErgoTree header, check no bytes left unconsumed after ErgoTree is parsed #684

Merged
merged 6 commits into from
Feb 7, 2023

Conversation

greenhat
Copy link
Member

@greenhat greenhat commented Feb 3, 2023

Ref #677
Close #587

check no bytes left unconsumed after ErgoTree is parsed;
@coveralls
Copy link

coveralls commented Feb 3, 2023

Pull Request Test Coverage Report for Build 4113135832

  • 120 of 137 (87.59%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.07%) to 63.482%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ergotree-ir/src/ergo_tree/tree_header.rs 28 29 96.55%
ergotree-ir/src/chain/ergo_box/box_id.rs 0 2 0.0%
ergotree-ir/src/chain/json/ergo_box.rs 0 3 0.0%
ergotree-ir/src/ergo_tree.rs 92 103 89.32%
Files with Coverage Reduction New Missed Lines %
ergo-p2p/src/peer_database/in_memory.rs 1 85.71%
ergotree-ir/src/serialization/types.rs 2 84.97%
Totals Coverage Status
Change from base Build 4064537449: 0.07%
Covered Lines: 10100
Relevant Lines: 15910

💛 - Coveralls

@greenhat greenhat marked this pull request as ready for review February 7, 2023 12:16
@greenhat greenhat merged commit 1d269b6 into develop Feb 7, 2023
@greenhat greenhat deleted the i677-block-fail-box-id branch February 7, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Box id parsed from JSON differs from calculated
2 participants