Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve ContextExtension items order in JSON encoding #687

Merged
merged 4 commits into from
Feb 7, 2023

Conversation

greenhat
Copy link
Member

@greenhat greenhat commented Feb 7, 2023

Add tx ids in tx id error on JSON parsing.

Close #685

add tx ids in tx id error on JSON parsing;
@greenhat greenhat changed the title preserve ContextExtension items order in JSON encoding; Preserve ContextExtension items order in JSON encoding Feb 7, 2023
@coveralls
Copy link

coveralls commented Feb 7, 2023

Pull Request Test Coverage Report for Build 4114114465

  • 3 of 8 (37.5%) changed or added relevant lines in 3 files are covered.
  • 17 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.06%) to 63.414%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ergotree-ir/src/chain/json/ergo_box.rs 0 1 0.0%
ergo-lib/src/chain/json/transaction.rs 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
ergo-rest/src/api/peer_discovery_internals/non_chrome.rs 2 73.28%
ergotree-ir/src/chain/token.rs 5 72.58%
ergotree-ir/src/serialization/types.rs 10 80.77%
Totals Coverage Status
Change from base Build 4113784281: -0.06%
Covered Lines: 10091
Relevant Lines: 15913

💛 - Coveralls

@greenhat greenhat marked this pull request as ready for review February 7, 2023 15:34
@greenhat greenhat merged commit 426c247 into develop Feb 7, 2023
@greenhat greenhat deleted the i685-contextext-order-json branch February 7, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preserve ContextExtension items order to\from JSON encoding
2 participants