Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace num256 with bnum #779

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Replace num256 with bnum #779

merged 1 commit into from
Nov 25, 2024

Conversation

SethDusek
Copy link
Collaborator

num256 has no no_std support and uses BigInt internally, so it'll be less efficient for fixed-size ops compared to bnum

Part of #778

@SethDusek SethDusek changed the title Replace BigInt256 internals with bnum Replace num256 with bnum Nov 13, 2024
num256 has no no_std support and uses BigInt internally, so it'll be less efficient for fixed-size ops compared to bnum
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11835992403

Details

  • 65 of 70 (92.86%) changed or added relevant lines in 7 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.005%) to 78.658%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ergotree-ir/src/bigint256.rs 44 49 89.8%
Files with Coverage Reduction New Missed Lines %
ergotree-ir/src/sigma_protocol/sigma_boolean.rs 1 69.03%
ergo-p2p/src/peer_database/in_memory.rs 1 86.36%
ergotree-ir/src/serialization/types.rs 6 82.58%
Totals Coverage Status
Change from base Build 11817168621: 0.005%
Covered Lines: 11009
Relevant Lines: 13996

💛 - Coveralls

@SethDusek SethDusek marked this pull request as ready for review November 25, 2024 08:42
@SethDusek SethDusek merged commit 61a345e into develop Nov 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants