Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.0] Improved and correct testing of newFeature test cases #1001

Merged
merged 1 commit into from
Jun 9, 2024
Merged

[6.0] Improved and correct testing of newFeature test cases #1001

merged 1 commit into from
Jun 9, 2024

Conversation

kushti
Copy link
Member

@kushti kushti commented Jun 6, 2024

In this PR:

  • SigmaDslSpecification is refactored to LanguageSpecificationV5 and V6.
  • Feature.isSupportedBy(versionContext) method implemented to allow correct testing of newFeature test cases
  • All newFeature tests moved to LanguageSpecificationV6

@kushti kushti added this to the v6.0 milestone Jun 6, 2024
@kushti kushti requested a review from aslesarenko June 7, 2024 10:40
@kushti kushti force-pushed the v6.0-newfeature branch from 07b8644 to e7bd2a3 Compare June 8, 2024 18:49
@kushti kushti merged commit 17ab381 into v6.0.0 Jun 9, 2024
4 checks passed
@kushti kushti deleted the v6.0-newfeature branch June 9, 2024 08:53
@kushti kushti mentioned this pull request Jun 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslesarenko aslesarenko aslesarenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kushti @aslesarenko