[6.0] New collection methods #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…preter into i1004
aslesarenko
approved these changes
Oct 4, 2024
| * @return the element at the given index | ||
| * @throws ArrayIndexOutOfBoundsException if `i < 0` or `length <= i` | ||
| */ | ||
| def get(i: Int): Option[A] = { |
There was a problem hiding this comment.
ScalaDoc doesn't correspond to the method.
| @@ -76,6 +92,14 @@ trait Coll[@specialized A] { | |||
| * produces a collection ((x0, y0), ..., (xK, yK)) where K = min(N, M) */ | |||
| def zip[@specialized B](ys: Coll[B]): Coll[(A, B)] | |||
|
|
|||
| /** For this collection (x0, ..., xN) and other collection (y0, ..., yM) | |||
| * produces a collection ((x0, y0), ..., (xK, yK)) where K = min(N, M) */ | |||
| def startsWith(ys: Coll[A]): Boolean | |||
|
|
||
| /** For this collection (x0, ..., xN) and other collection (y0, ..., yM) | ||
| * produces a collection ((x0, y0), ..., (xK, yK)) where K = min(N, M) */ | ||
| def endsWith(ys: Coll[A]): Boolean |
| @@ -350,6 +354,10 @@ class PairOfCols[@specialized L, @specialized R](val ls: Coll[L], val rs: Coll[R | |||
|
|
|||
| def zip[@specialized B](ys: Coll[B]): PairColl[(L,R), B] = builder.pairColl(this, ys) | |||
|
|
|||
| def startsWith(ys: Coll[(L, R)]): Boolean = toArray.startsWith(ys.toArray) | |||
|
|
|||
| def endsWith(ys: Coll[(L, R)]): Boolean = toArray.endsWith(ys.toArray) | |||
There was a problem hiding this comment.
This is simple, but inefficient ((ys.length + 1)*2 allocations) fallback implementation.
In the case when ys has type PairOfCols, it is possible to recursively call into ls and rs, and avoid allocations.
| // ======== 6.0 methods below =========== | ||
|
|
||
| val ReverseMethod = SMethod(this, "reverse", | ||
| SFunc(Array(ThisType), ThisType, paramIVSeq), 30, Zip_CostKind) // todo: costing |
There was a problem hiding this comment.
Suggest to declare the descriptor by just cloning from Append (Zip is too small).
| } | ||
|
|
||
| val DistinctMethod = SMethod(this, "distinct", | ||
| SFunc(Array(ThisType), ThisType, paramIVSeq), 31, Zip_CostKind) // todo: costing |
There was a problem hiding this comment.
The cost of distinct is larger then zip or Append, probably by a factor of 2.
| Seq( | ||
| Coll(1, 2) -> Expected(ExpectedResult(Success(Coll(1, 2)), None)), | ||
| Coll(1, 1, 2) -> Expected(ExpectedResult(Success(Coll(1, 2)), None)), | ||
| Coll(1, 2, 2) -> Expected(ExpectedResult(Success(Coll(1, 2)), None)), |
There was a problem hiding this comment.
Suggest to add a case with unordered collections and many different duplicates.
| (Coll(1, 2, 3), Coll(1, 2)) -> Expected(ExpectedResult(Success(true), None)), | ||
| (Coll(1, 2, 3), Coll(1, 2, 3)) -> Expected(ExpectedResult(Success(true), None)), | ||
| (Coll(1, 2, 3), Coll(1, 2, 3, 4)) -> Expected(ExpectedResult(Success(false), None)), | ||
| (Coll[Int](), Coll[Int]()) -> Expected(ExpectedResult(Success(true), None)) |
There was a problem hiding this comment.
Not covered cases:
- Coll(1, 2, 3), Coll(1, 2, 4)
- Coll[Int](1, 2), CollInt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, new collection methods got introduced:
close #1004