Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate GF classes to Scala (restructure part3) #866

Merged
merged 10 commits into from
Feb 27, 2023

Conversation

aslesarenko
Copy link
Member

@aslesarenko aslesarenko commented Feb 22, 2023

In this PR all GF classes migrated to Scala (step towards Sigma.js).
The regression was tested by comparing result of each operation between new Scala and old Java code and ensuring that all Sigma tests pass (see this commit for details)

@codecov
Copy link

codecov bot commented Feb 26, 2023

Codecov Report

Merging #866 (0f4fa86) into v5.0.6-RC (250922b) will increase coverage by 0.11%.
The diff coverage is 84.35%.

@@              Coverage Diff              @@
##           v5.0.6-RC     #866      +/-   ##
=============================================
+ Coverage      75.59%   75.71%   +0.11%     
=============================================
  Files            218      220       +2     
  Lines          14180    14357     +177     
  Branches         458      512      +54     
=============================================
+ Hits           10720    10870     +150     
- Misses          3460     3487      +27     
Impacted Files Coverage Δ
...tate/src/main/scala/sigmastate/SigSerializer.scala 98.33% <ø> (ø)
...tate/src/main/scala/sigmastate/UncheckedTree.scala 55.55% <ø> (ø)
...state/src/main/scala/sigmastate/UnprovenTree.scala 100.00% <ø> (ø)
...rc/main/scala/sigmastate/crypto/GF2_192_Poly.scala 79.59% <79.59%> (ø)
...ate/src/main/scala/sigmastate/crypto/GF2_192.scala 85.93% <85.93%> (ø)
...tate/src/main/scala/org/ergoplatform/ErgoBox.scala 92.30% <100.00%> (ø)
...ala/sigmastate/interpreter/ProverInterpreter.scala 95.71% <100.00%> (ø)
core/src/main/scala/scalan/MethodCalls.scala 56.45% <0.00%> (+1.61%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aslesarenko aslesarenko requested a review from kushti February 27, 2023 11:42
@aslesarenko aslesarenko marked this pull request as ready for review February 27, 2023 11:42
@aslesarenko aslesarenko merged commit 3c7a72d into v5.0.6-RC Feb 27, 2023
@aslesarenko aslesarenko deleted the restructure-part3 branch April 21, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants