Add missing CryptoFacade methods #874
Conversation
Codecov Report
@@ Coverage Diff @@
## v5.0.7-RC #874 +/- ##
=============================================
- Coverage 80.58% 80.54% -0.04%
=============================================
Files 219 220 +1
Lines 13992 14002 +10
Branches 464 462 -2
=============================================
+ Hits 11275 11278 +3
- Misses 2717 2724 +7
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| @@ -46,6 +51,12 @@ object Platform { | |||
| /** Returns byte representation of the given field element. */ | |||
| def encodeFieldElem(p: ECFieldElem): Array[Byte] = p.value.getEncoded | |||
|
|
|||
| /** Returns byte representation of the given point. | |||
There was a problem hiding this comment.
"Returns" is already in the code. "byte representation of the given point." is enough
There was a problem hiding this comment.
Fixed, no problem, but does it really worth to spend efforts on this? I don't think we should be so strict in our reviews. Do you want me to follow the same strict standard, I assume yes?
There was a problem hiding this comment.
What standard are you following during review? Any link ?
There was a problem hiding this comment.
This is figuratively speaking "standard". You establish the review rules here, and I try to follow them while reviewing Ergo PRs.
There was a problem hiding this comment.
And vice versa. Why not to standardize them then? It would be good for sure to avoid comments about "black names" etc
interpreter/src/main/scala/sigmastate/crypto/CryptoContext.scala
Outdated
Show resolved
Hide resolved
interpreter/src/main/scala/sigmastate/crypto/CryptoFacade.scala
Outdated
Show resolved
Hide resolved
interpreter/src/main/scala/sigmastate/crypto/CryptoFacade.scala
Outdated
Show resolved
Hide resolved
In this PR the following methods added:
These methods are used in Ergo node.