[6.0] UnsignedBigInt implementation #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kushti the target branch seems to be not correct. I wonder if the changeset is so big because of that? |
weird it no retargeted automatically after merged, fixed manually |
aslesarenko
requested changes
Nov 27, 2024
| @@ -55,6 +55,7 @@ trait ContractSyntax { contract: SigmaContract => | |||
| case _: String => StringType | |||
| case _: Unit => UnitType | |||
| case _: sigma.BigInt => BigIntRType | |||
| case _: sigma.BigInt => UnsignedBigIntRType | |||
| (newName, Select(obj, newName, resType)) | ||
| } else { | ||
| (nOriginal, selOriginal) | ||
| } |
There was a problem hiding this comment.
Hm, why not just use different method names? This will be the only place with such exception, so will lead to more questions than answers.
There was a problem hiding this comment.
The idea is to provide unified interface to users (ErgoScript) developers, so kinda polymorphic exp method (which is then translated by typer into exp or expUnsigned, depends on argument)
sc/shared/src/test/scala/sigmastate/ErgoTreeSpecification.scala
Outdated
Show resolved
Hide resolved
sdk/shared/src/main/scala/org/ergoplatform/sdk/JavaHelpers.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander Slesarenko <aslesarenko@users.noreply.github.com>
Co-authored-by: Alexander Slesarenko <aslesarenko@users.noreply.github.com>
Co-authored-by: Alexander Slesarenko <aslesarenko@users.noreply.github.com>
|
@aslesarenko comments addressed, please make another pass! |
aslesarenko
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains implementation of new numeric type, UnsignedBigInt, 256 bits unsigned big integers.